Comment out network vars in all.sample.yml to rely on role defaults#759
Conversation
|
/test ? |
|
/test deploy-mno |
1 similar comment
|
/test deploy-mno |
| msg: "public_vlan is enabled but controlplane_network uses the default private range. Comment out controlplane_network and controlplane_network_prefix in all.yml to use public VLAN auto-configuration." | ||
| when: | ||
| - public_vlan | default(false) | ||
| - "'198.18.0.0/16' in controlplane_network" |
There was a problem hiding this comment.
Need to check if controlplane_network is defined first. However even worse is that it seems somehow the default in the following role in the networks.yml vars file is populated before it is used thus the value remains assigned when I was debugging the CI failure. Even if we then remove that definition, a later validation for controlplane_network to be a list will also fail. We should also move from fail to assert tasks as those better match the goal of validate vars perhaps before adding more validations.
There was a problem hiding this comment.
I took another approach to comment all the network related variables in all.sample.yml and rely on the networks.yml defaults. This way the vars can be overridden automatically when public_vlan is set to true.
mcornea
force-pushed
the
public_vlan_validation
branch
from
33cd82b to
7d9bff8
Compare
Comment out the network variable definitions in all.sample.yml so they fall through to role defaults and allow them to be dynamically set when public_vlan is set to true. Signed-off-by: Marius Cornea <mcornea@redhat.com>
mcornea
changed the title
|
/test deploy-mno |
mcornea
force-pushed
the
public_vlan_validation
branch
from
7d9bff8 to
c65c8e1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrzos The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 975cf7b
into
redhat-performance:main
2 participants
Comment out the network variable definitions in all.sample.yml sothey fall through to role defaults and allow them to be dynamically set when public_vlan is set to true.