-
Couldn't load subscription status.
- Fork 52
Add agent framework recipe #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "\n", | ||
| "This notebook demonstrates how to build an agent using Microsoft's [Agent Framework](https://github.com/microsoft/agent-framework/tree/main).\n", | ||
| "\n", | ||
| "It adapts the work found in [Redis-AI-Resources Autogen Agent Tutorial](https://github.com/redis-developer/redis-ai-resources/blob/main/python-recipes/agents/04_autogen_agent.ipynb), and simply applies the setting in Agent Framework instead.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can trim this reference out of here for cleanliness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! left a few small comments to consider. also test is failing
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "gpg: cannot open '/dev/tty': No such device or address\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you omit the ugly error/warning here from notebook output?
| "for restaurant in restaurant_reviews:\n", | ||
| " for field in ['region', 'country', 'tel', 'fax', 'email', 'website', 'address_extended', 'chain_name', 'trip_advisor_url']:\n", | ||
| " if field in restaurant:\n", | ||
| " restaurant.pop(field)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best practice here would be to show a single sample of the data to help the reader see what we are working with
No description provided.