retry connection prelude on connect errors #276
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdrew
force-pushed
the
wrongpass-retry
branch
from
ab5415c to
aba5b7b
Compare
byroot
reviewed
Dec 20, 2025
Comment on lines
-845
to
-858
| rescue FailoverError, CannotConnectError => error | ||
| error._set_config(config) | ||
| raise error | ||
| rescue ConnectionError => error | ||
| connect_error = CannotConnectError.with_config(error.message, config) | ||
| connect_error.set_backtrace(error.backtrace) | ||
| raise connect_error | ||
| rescue CommandError => error | ||
| if error.message.match?(/ERR unknown command ['`]HELLO['`]/) | ||
| raise UnsupportedServer, | ||
| "redis-client requires Redis 6+ with HELLO command available (#{config.server_url})" | ||
| else | ||
| raise | ||
| end |
Member
There was a problem hiding this comment.
I don't understand why you moved these rescues. Now only the send_prelude call in connect is covered.
byroot
reviewed
Dec 20, 2025
| assert_match(/WRONGPASS invalid username-password pair/, error.message) | ||
|
|
||
| # Correct password, but user disabled | ||
| backup.call("ACL", "SETUSER", "AzureDiamond", "<hunter2", ">trolilol", "off") |
Member
There was a problem hiding this comment.
Mutating an existing user, and trying to fix it in a rescue isn't good, as it may fail and leave the server in a state that fail other tests.
You can create a different user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.