Skip to content

ci: remove minitest benchmark codes #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
supercaracal merged 1 commit into from
Dec 20, 2025
Merged

ci: remove minitest benchmark codes #454

supercaracal merged 1 commit into from
Dec 20, 2025

Conversation

@supercaracal
Copy link
Member

@supercaracal supercaracal commented Dec 20, 2025 •
edited
Loading

We are using benchmark-ips for our benchmark, so we do not need minitest/benchmark anymore.

/home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest/benchmark.rb:20:in 'run': wrong number of arguments (given 3, expected 1..2) (ArgumentError)
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:467:in 'block (2 levels) in Minitest::Runnable.run_suite'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:463:in 'Array#each'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:463:in 'block in Minitest::Runnable.run_suite'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:505:in 'Minitest::Runnable.on_signal'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:492:in 'Minitest::Runnable.with_info_handler'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:462:in 'Minitest::Runnable.run_suite'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:355:in 'block in Minitest.run_all_suites'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:355:in 'Array#map'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:355:in 'Minitest.run_all_suites'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:310:in 'Minitest.run'
	from /home/runner/work/redis-cluster-client/redis-cluster-client/vendor/bundle/ruby/3.4.0/gems/minitest-6.0.0/lib/minitest.rb:84:in 'block in Minitest.autorun'

@supercaracal supercaracal marked this pull request as ready for review December 20, 2025 04:16
@supercaracal supercaracal merged commit 5fc36bb into redis-rb:master Dec 20, 2025
25 of 28 checks passed
@supercaracal supercaracal deleted the remove-minitest-bench branch December 20, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@supercaracal