Open
Conversation
* Make it compile. * Ignore Eclipse project files.
Finesse around a probable PaperSpigot bug to ensure that limit does not get set to 0 instead.
Fix error handling for extra arguments.
User-facing commands that dealt in "careers" now operate on "professions" instead.
Later, we may add `/vtrade` subcommands as subcommands of `/villager` too. We may also add `/villager experience` to set the trading experience of the villager. Let's avoid a future name clash.
The code looks right. I tried setting max uses on each recipe but that didn't help. Looks like it is not possible to refresh trades via the Bukkit API. So, for now, the command is not enabled.
Author
|
This commit combines the v1.2.0 (1.13.2) and v2.0.0 (1.4.3) changes. If you're not interested in maintaining this repo any longer @redwallhp, would you consider assigning it to the NerdNu organisation? |
Extend trade editing support to wandering traders. Document limitations and suggested preparations.
Prevent villagers from being named when the player does not have build permission at the villager's location.
…updated Pom.xml and Plugin.yml
HOTV disabler added, some dependencies updated
`OldEnum#toString` no longer returns a simple key representation in 1.21.10, breaking command feedback for `/villager spawn` and `/villager spawnfile`. This also broke serialization to file. This replaces `OldEnum#toString` with `getKey` followed by `NamespacedKey#getKey` to get the unscoped key, matching previous behavior for both 1.21.8 and 1.21.10.
A villager's profession will reset if they do not have a job site, have 0 XP, and level <= 1. To avoid this scenario, we will default level to 5. If level 1 is explicitly requested, we employ a workaround setting XP to 1.
Fix villagers losing profession immediately after `/villager spawn`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the release description: https://github.com/totemo/VillagerUtils/releases/tag/v1.2.0