Skip to content

Update cs2 profiles, renaming -short into -to2050#2326

Merged
lecfab merged 2 commits intoremindmodel:developfrom
lecfab:remind360
Apr 1, 2026
Merged

Update cs2 profiles, renaming -short into -to2050#2326
lecfab merged 2 commits intoremindmodel:developfrom
lecfab:remind360

Conversation

@lecfab
Copy link
Copy Markdown
Contributor

@lecfab lecfab commented Mar 30, 2026

Purpose of this PR

Aesthetics changes in compareScenarios profiles:

  • Rename all *-short profiles to *-to2050
  • Add profile H12-to2060: I use it for fossil phase-out, other people may need it for net-zero targets etc
  • yearsHist now goes until current year (2026 atm) in yearly steps, then 5-yearly. Maybe this could happen in piamPlotComparison instead.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ☑️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

@lecfab lecfab requested a review from fbenke-pik March 30, 2026 14:49
@fbenke-pik
Copy link
Copy Markdown
Contributor

From a technical standpoint, this should be fine. Please get a review from people like @robertpietzcker or @LaviniaBaumstark to confirm that the renaming of central profiles is indeed fine.

@robertpietzcker
Copy link
Copy Markdown
Contributor

fine with me!

@lecfab lecfab merged commit 87f490a into remindmodel:develop Apr 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants