This repository was archived by the owner on Apr 28, 2025. It is now read-only.
feat: upgrade to Remix v2#207
Merged
MichaelDeBoey merged 1 commit intoremix-run:mainfrom Sep 15, 2023
Merged
Conversation
MichaelDeBoey
requested review from
brophdawg11,
jacob-ebey,
markdalgleish and
pcattori
MichaelDeBoey
force-pushed
the
v2
branch
3 times, most recently
from
ea97262 to
6c159bb
Compare
brophdawg11
reviewed
Sep 12, 2023
Contributor
brophdawg11
left a comment
brophdawg11
left a comment
There was a problem hiding this comment.
Looking good - similar comments as the indie stack.
Installation ran fine but I couldn't validate the npm run dev step because we don't have docker on our Shopify machines.
> npx create-remix@pre --template https://github.com/MichaelDeBoey/blues-stack/tree/v2 -y blues-v2
> cd blues-v2
> npx upgrade-remix pre
> npm run dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like I did in remix-run/indie-stack#257