This repository was archived by the owner on Apr 28, 2025. It is now read-only.
chore: bring in line with latest arc template#165
Merged
MichaelDeBoey merged 1 commit intoremix-run:mainfrom Sep 7, 2023
Merged
chore: bring in line with latest arc template#165MichaelDeBoey merged 1 commit intoremix-run:mainfrom
MichaelDeBoey merged 1 commit intoremix-run:mainfrom
Conversation
MichaelDeBoey
requested review from
brophdawg11,
jacob-ebey,
markdalgleish and
pcattori
mcansh
reviewed
Sep 6, 2023
MichaelDeBoey
force-pushed
the
bring-in-line-with-arc-template
branch
from
f4b513f to
babe8bb
Compare
MichaelDeBoey
force-pushed
the
bring-in-line-with-arc-template
branch
from
babe8bb to
93963ef
Compare
brophdawg11
approved these changes
Sep 7, 2023
Contributor
brophdawg11
left a comment
brophdawg11
left a comment
There was a problem hiding this comment.
Works in node 14 and 20 for me 👍
mcansh
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this also enables ESM mode, I had to do some extra things for this repo specific (things that I also had to do in remix-run/indie-stack#255 & remix-run/blues-stack#206)