Adapt z3 constraint checking logic to windows#1069
Adapt z3 constraint checking logic to windows#1069wanghuibin0 wants to merge 1 commit intorems-project:sail2from
Conversation
On Windows, the output of z3 has a trailing \r, which makes checking of result = 'unsat' return false. Checking the prefix of the output is enough and it adapts to different types of OS.
|
Could you help review this PR? @Alasdair |
|
I think a problem with this is z3 often produces output like: so it's actually unsafe to just check the prefix |
|
Although the output is split by lines, so maybe that's not really a problem. However, reading the code more closely I think the problem is really that |
|
Ah, at present I discovered only this issue when I run sail on Windows. |
On Windows, the output of z3 has a trailing \r, which makes checking of "result = 'unsat'" return false.
Checking the prefix of the output is enough and it adapts to different types of OS.