Skip to content

Conversation

@allan-thatch
Copy link
Contributor

Add support for using customer-managed KMS keys and bucket keys for encryption.

@allan-thatch allan-thatch marked this pull request as ready for review December 18, 2025 20:29
allan-thatch added a commit to thatch-health/render-auditlogs that referenced this pull request Dec 18, 2025
Add support for using customer-managed KMS keys and bucket keys for encryption.

This is a fork version of render-examples#2.
@oleg-render
Copy link

Great addition! Our current s3 bucket policy will actually block KMS-encrypted uploads because it requires AES256 encryption. When using KMS, the encryption type is "aws:kms".
If using KMS we should not include that constraint (replace with aws:kms) and enforce kms keys with conditions:

condition = {                                                                                                                                                                                                
  StringEquals = {                                                                                                                                                                                                                                                              
  "s3:x-amz-server-side-encryption" = "aws:kms"                                                                                                                                                                
  },                                                                                                                                                                                                           
  Null = {                                                                                                                                                                                                     
  "s3:x-amz-server-side-encryption-aws-kms-key-id" = "true"                                                                                                                                                    
  }                                                                                                                                                                                                            
}

@allan-thatch
Copy link
Contributor Author

Great catch! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants