add setOptions function, revised update function to allow for new options#142
Open
mezmi wants to merge 2 commits intorendro:masterfrom
mezmi:master
Open
add setOptions function, revised update function to allow for new options#142mezmi wants to merge 2 commits intorendro:masterfrom mezmi:master
mezmi wants to merge 2 commits intorendro:masterfrom
mezmi:master
Conversation
added 2 commits
May 28, 2015 13:22
added the ability to pass a new set of chart options in the update method, useful for changing colors while updating, ect..
Author
|
@rendro Any ideas why this Travis CI build fails? Details are a bit sketchy... PhantomJS is complaining saying this: I didn't mess with any of the default values, simply added another parameter to the update function and included 7ever's setOptions function. Everything seems to function properly on my end. |
Owner
|
@enkimatt Don't worry about the Travis CI results. The rest cases are broken at the moment. I'll have a look at your PR soon. Thanks for your contribution. |
Author
|
My contribution is minimal, I should be thanking you - so, Thank you.. LOL. This chart is awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a setOptions function and revised the update function to allow for new options to be passed to the chart.
Example.