Make the animation last a percentage of the total time#27
Open
fuelxc wants to merge 1 commit intorendro:masterfrom
Open
Make the animation last a percentage of the total time#27fuelxc wants to merge 1 commit intorendro:masterfrom
fuelxc wants to merge 1 commit intorendro:masterfrom
Conversation
Collaborator
|
@rendro, what do you think about it? |
Owner
|
Since there are only a few changes needed I am fine with it. Maybe we find a more descriptive key for the option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not familiar with coffee script, I use JS, so I made my modifications in there.
I have several pie charts that are related and I wanted them to all move at the same rate, but just stop when they get to their correct point on the graph so I added a config option animatePercentOf that will take the percentage of the animation time for the given graph.