fix(external-match): correct artifact paths for CommonJS bundlers#265
Merged
fix(external-match): correct artifact paths for CommonJS bundlers#265
Conversation
akirillo
force-pushed
the
andrew/fix-external-match-artifacts
branch
from
1b1d76e to
487632c
Compare
sehyunc
approved these changes
Feb 12, 2026
akirillo
force-pushed
the
andrew/fix-external-match-artifacts
branch
from
487632c to
769b5fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we fix the paths at which older bundlers/resolution types expect to find the
external-matchpackage's build artifacts & types.We also add an optional
gasfield to theSettlementTx, which is present when a bundle is requested/assembled with.withGasEstimation(true).