Allow glob special characters on import-sort-cli paths#127
Open
nfantone wants to merge 3 commits intorenke:masterfrom
Open
Allow glob special characters on import-sort-cli paths#127nfantone wants to merge 3 commits intorenke:masterfrom
import-sort-cli paths#127nfantone wants to merge 3 commits intorenke:masterfrom
Conversation
Author
|
Wanted to point out that, seeing how little activity there seems to be in this repository, users can workaround this issue by locking the "resolutions": {
"import-sort-cli/globby": "11.0.1"
}This might have other unintended effects (as |
|
Thanks @nfantone and npm solution matched the version from another use on my package tree.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File paths passed to
import-sort-clicontaining glob special characters -such as[,(,]and)- would not work with currently setglobbydependency even though they are valid.Upgrading
globbyto11.0.1resolves the issue. However, the following was also addressed:globbytypes for latest release required a newertypescriptversion.import-sortwould not build due to TS errors onpackages/import-sort-parser-babylon/src/index.ts.eslintconfig declares@typescript-eslint/parseras parser but the module was never installed as a dependency, forcinglint-stagedscripts to fail.