Skip to content

Conversation

@ignaciosantise
Copy link
Collaborator

No description provided.

ignaciosantise and others added 2 commits August 21, 2025 17:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 21, 2025 22:28
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: 935839a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new CLI package for the Reown AppKit React Native toolkit. The CLI provides an easy way for developers to scaffold new React Native projects using the AppKit template.

  • Adds a new @reown/appkit-react-native-cli package with initialization functionality
  • Creates a command-line interface that uses Expo's create-expo tool with a predefined template
  • Includes proper TypeScript configuration and build setup for the CLI package

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/cli/package.json Package configuration for the new CLI with dependencies and build scripts
packages/cli/src/index.ts Main CLI entry point that spawns expo create with template URL
packages/cli/src/utils.ts ASCII art banner for the CLI
packages/cli/tsconfig.json TypeScript configuration extending root config
packages/cli/bob.config.js Build configuration for CommonJS, ES modules, and TypeScript outputs
packages/cli/CHANGELOG.md Changelog documenting the initial CLI feature
packages/cli/.npmignore NPM ignore file excluding source files from published package
package.json Root package.json updated to include the new CLI package in workspaces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

await runExpoCreate();
} catch (error: any) {
// eslint-disable-next-line no-console
console.error('Failed to run Expo initializer:', error?.message || error);
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'any' type defeats the purpose of TypeScript's type safety. Consider using 'unknown' type instead and properly type guard the error, or create a specific error type.

Suggested change
console.error('Failed to run Expo initializer:', error?.message || error);
} catch (error: unknown) {
// eslint-disable-next-line no-console
let errorMessage: string;
if (typeof error === 'object' && error !== null && 'message' in error && typeof (error as any).message === 'string') {
errorMessage = (error as { message: string }).message;
} else {
errorMessage = String(error);
}
console.error('Failed to run Expo initializer:', errorMessage);

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants