Skip to content

Conversation

@ignaciosantise
Copy link
Collaborator

@ignaciosantise ignaciosantise commented Oct 23, 2025

This pull request makes a minor update to the CI/CD workflow configuration to ensure that GitHub Actions trigger on the correct branches. Specifically, it changes the workflow triggers from the development branch to the develop branch.


Note

Update GitHub Actions workflow to trigger on the develop branch (instead of development) for push and pull_request events.

Written by Cursor Bugbot for commit f65a954. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings October 23, 2025 17:19
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

⚠️ No Changeset found

Latest commit: f65a954

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI/CD workflow configuration to align branch names with the project's naming convention by changing references from development to develop.

Key Changes:

  • Updated GitHub Actions workflow triggers to use the develop branch name instead of development

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@claude
Copy link

claude bot commented Oct 23, 2025

Claude finished @ignaciosantise's task —— View job


Code Review Complete ✅

Tasks

  • Read the modified workflow file
  • Check for other references to "development" branch
  • Assess changes for correctness and completeness
  • Post comprehensive review feedback

Review Summary

No issues found - The changes correctly update the CI/CD workflow triggers from development to develop.

Analysis

What was changed:

  • .github/workflows/expo-ci-cd.yml:9 - Updated push trigger from development to develop
  • .github/workflows/expo-ci-cd.yml:24 - Updated pull_request trigger from development to develop

Consistency check:

  • ✅ Other workflow files (.github/workflows/expo-update.yml and .github/workflows/expo-preview.yml) already reference develop correctly
  • ✅ The remote branch origin/develop exists
  • ✅ No other workflow files reference development as a branch trigger

Changeset requirement:
The changeset-bot flagged that no changeset was added. This is appropriate - workflow configuration changes are infrastructure updates that don't affect package versions or public APIs. No changeset is needed for this type of change.

Conclusion

This is a straightforward and correct fix that aligns the expo-ci-cd.yml workflow with the actual branch naming convention used throughout the repository. The changes are complete and no additional updates are required.


@sonarqubecloud
Copy link

@ignaciosantise ignaciosantise merged commit 3097655 into develop Oct 23, 2025
11 of 16 checks passed
@ignaciosantise ignaciosantise deleted the chore/test branch October 23, 2025 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants