feat: adds tron versioned transactions #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
8 Skipped Deployments
|
Deploying demo-ai-agents with
|
| Latest commit: |
948ed21
|
| Status: | 🚫 Build failed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive TRON blockchain support to both the wallet and dApp implementations, including transaction signing with backward compatibility for different structure versions.
- Adds TRON balance fetching and display functionality
- Implements TRON transaction and message signing with version compatibility
- Adds TRON logo assets and chain metadata
- Introduces session property for TRON method version negotiation
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| advanced/wallets/react-wallet-v2/src/views/SessionProposalModal.tsx | Adds TRON-specific session property to indicate v1 method version support |
| advanced/wallets/react-wallet-v2/src/utils/TronRequestHandlerUtil.ts | Implements backward compatibility for both old (nested) and new (flat) transaction structures |
| advanced/wallets/react-wallet-v2/src/lib/TronLib.ts | Updates signTransaction to work with unwrapped transaction objects |
| advanced/wallets/react-wallet-v2/public/chain-logos/tron.png | Adds TRON logo for wallet UI |
| advanced/dapps/react-dapp-v2/src/helpers/tron.ts | Fixes control flow to return TronWeb instances correctly for all code paths |
| advanced/dapps/react-dapp-v2/src/helpers/api.ts | Implements TRON balance fetching with network-specific endpoints |
| advanced/dapps/react-dapp-v2/src/contexts/JsonRpcContext.tsx | Adds TRON transaction/message signing with version-aware parameter structuring and updated TronWeb API calls |
| advanced/dapps/react-dapp-v2/src/components/Asset.tsx | Adds TRX token icon support in asset display |
| advanced/dapps/react-dapp-v2/src/chains/tron.ts | Updates TRON metadata to use local logo assets instead of external URLs |
| advanced/dapps/react-dapp-v2/public/assets/tron.png | Adds TRON logo for dApp UI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #917
This PR adds comprehensive TRON blockchain support to both the wallet and dApp implementations, including transaction signing with backward compatibility for different structure versions.