Use startOsmNode/endOsmNode to fix barrier node graph gaps#25
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…/endVertex The OSM export assigns different internal vertex IDs to the same physical intersection at barrier nodes (gates, bollards), creating disconnected gaps in the graph. The startOsmNode/endOsmNode columns resolve these splits back to the original OSM node ID, so both sides of a barrier share the same node. The loader now prefers startOsmNode/endOsmNode and falls back to startVertex/endVertex for backwards compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startVertex/endVertex) to the same physical intersection at barrier nodes (gates, bollards), creating disconnected gaps in the road graphstartOsmNode/endOsmNodeinstead, which resolve barrier splits back to the original OSM node IDRoot cause
OSM way
413669941(a secondary road in NM) is split into segments at a barrier point. Segments_0and_1meet at the same coordinates but use different vertex IDs (66538974 vs 66538975), with no edge connecting them. ThestartOsmNode/endOsmNodecolumns both resolve to the shared OSM node4149455795.This caused OpenLR decode failures ("No valid path found between points 1 and 2") when the only bypass route used service roads filtered out by
ALLOWS_CAR.Test plan
C7Ss1RgrDyOduepbIK8jn7n61iS9I5+5/twlaCMYsucceeds in openlr-web with NM network usingstartOsmNode/endOsmNodecolumns🤖 Generated with Claude Code