Fix schema incompatibility check #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were using a flat dict structure for Input schemas:
{"Input": {"text": {...}}}
But the real schema structure from get_schemas has a "properties" wrapper:
{"Input": {"type": "object", "properties": {"text": {...}}}}
This masked a bug in check_backwards_compatible that was fixed in schema.py.
Added helper function make_input_schema() to properly construct test schemas
and a new test for train=True to cover TrainingInput schemas.
This test uses a full real-world schema structure with all the metadata (title, x-order, nullable, format, etc.) to ensure check_backwards_compatible correctly handles schemas returned from get_schemas().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.