Fix schema incompatibility check take 2 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allOf can contain either: 1. A $ref pointing to a separate schema 2. An inline enum definition directly The code was assuming $ref always exists, but real schemas often have the enum inlined in allOf[0] directly.
Added tests for enums defined inline in allOf (without $ref): - test_inline_enum_identical: no changes, should pass - test_inline_enum_added_choice: adding choices is backwards compatible - test_inline_enum_removed_choice: removing choices breaks compatibility - test_inline_enum_changed_type: changing enum type breaks compatibility
Since get_openapi_schema() calls dereference_schema(), all $ref are already resolved by the time check_backwards_compatible is called. The allOf will always contain the inline enum definition directly.
Since schemas are dereferenced before check_backwards_compatible, $ref is never present. Tests now use the realistic inline enum format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.