Add deadline API for tracked messages #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
waiting on fix from #225 |
to get a slice of tracked message values that have exceeded their deadline within a given time range into the past.
…line so that the `GC` can delete them without double checking.
meatballhat
force-pushed
the
client-deadline-exceeded
branch
from
a164928 to
1699e64
Compare
NikhilSinha1
approved these changes
Oct 14, 2025
Contributor
NikhilSinha1
left a comment
NikhilSinha1
left a comment
There was a problem hiding this comment.
Yeah, this makes sense to me. When CordonDeadlineExceeded gets called we grab everything where the deadline is in the past and move it to the garbage set. Then before we do the HScan, we remove all the predictions in the garbage set and GC it, and then we do the HScan and clean up the removed keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get a slice of tracked message values that have exceeded their deadline within a given time range into the past.