Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
163 changes: 98 additions & 65 deletions chartsmith-extension/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions chartsmith-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,17 @@
"@types/glob": "^8.1.0",
"@types/marked": "^5.0.2",
"@types/node": "20.2.5",
"@types/vscode": "^1.80.0",
"@types/vscode": "^1.107.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Type definitions version exceeds minimum engine requirement

The @types/vscode version (1.107.0) is significantly higher than the engines.vscode minimum version (^1.80.0). This mismatch means TypeScript type definitions include APIs that only exist in VS Code 1.107.0+, but the extension claims to support VS Code 1.80.0+. Code could compile successfully using newer APIs that don't exist at runtime for users on older VS Code versions, causing runtime failures. The @types/vscode version should typically match the engines.vscode version.

Additional Locations (1)

Fix in Cursor Fix in Web

"@types/ws": "^8.5.5",
"@typescript-eslint/eslint-plugin": "^5.59.8",
"@typescript-eslint/parser": "^5.59.8",
"@vscode/test-electron": "^2.3.2",
"@vscode/vsce": "^2.19.0",
"eslint": "^8.41.0",
"glob": "^8.1.0",
"ts-loader": "^9.4.3",
"typescript": "^5.1.3",
"webpack": "^5.85.0",
"ts-loader": "^9.5.4",
"typescript": "^5.9.3",
"webpack": "^5.103.0",
"webpack-cli": "^5.1.1"
},
"dependencies": {
Expand Down