Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
257 changes: 243 additions & 14 deletions chartsmith-extension/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion chartsmith-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"@types/vscode": "^1.80.0",
"@types/ws": "^8.5.5",
"@typescript-eslint/eslint-plugin": "^5.59.8",
"@typescript-eslint/parser": "^5.59.8",
"@typescript-eslint/parser": "^8.49.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incompatible major version mismatch between typescript-eslint packages

Upgrading @typescript-eslint/parser to v8.49.0 while keeping @typescript-eslint/eslint-plugin at v5.x creates a peer dependency conflict. The plugin explicitly requires @typescript-eslint/parser: "^5.0.0" as a peer dependency. These packages are designed to work together at the same major version and mixing v5 and v8 will cause npm warnings and likely runtime errors or unexpected linting behavior. Both packages need to be upgraded together to the same major version.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: ESLint version doesn't meet parser peer dependency requirements

The upgraded @typescript-eslint/parser v8.49.0 requires eslint: "^8.57.0 || ^9.0.0" as a peer dependency, but the project specifies eslint: "^8.41.0". ESLint versions 8.41.0 through 8.56.x won't satisfy this requirement, causing peer dependency warnings during installation and potential compatibility issues at runtime.

Additional Locations (1)

Fix in Cursor Fix in Web

"@vscode/test-electron": "^2.3.2",
"@vscode/vsce": "^2.19.0",
"eslint": "^8.41.0",
Expand Down