Update Makefile versions #3310
Open
Update Makefile versions #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| K0S_VERSION_1_33 = v1.33.6+k0s.0 | ||
| K0S_VERSION_1_32 = v1.32.10+k0s.0 | ||
| K0S_VERSION_1_31 = v1.31.12+k0s.0 | ||
| K0S_VERSION_1_31 = v1.31.14+k0s.0 |
There was a problem hiding this comment.
Bug: K0s version override and check incompatible with update
The K0S_VERSION_1_31 was updated from v1.31.12+k0s.0 to v1.31.14+k0s.0, but the override logic and validation checks at the bottom of versions.mk still reference the old version. The check-k0s-version target will fail because it expects any v1.31 version to be exactly v1.31.12+k0s.0-ec.0. The ifeq conditions on lines 43 and 51 that trigger the EC override and binary source will also no longer match, making builds with K0S_MINOR_VERSION=31 fail.
Additional Locations (2)
replicated-ci-ec
force-pushed
the
automation/update-makefile
branch
4 times, most recently
from
53e5634 to
9f1f361
Compare
replicated-ci-ec
force-pushed
the
automation/update-makefile
branch
from
9f1f361 to
9b7f6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by the cron-makefile-dependencies GitHub action