Fix Safari bug with flickering elements on drag #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not use "event.relatedTarget" to check if the native element still contains the dragged element because of a Safari bug with "NULL" as "event.relatedTarget" value on the dragleave event. See: https://stackoverflow.com/questions/68745781/dragevent-relatedtarget-returns-null-in-safari The solution is to use a counter instead of the related target that decrease on drag leave and increase on drag enter.
|
Hi, it would be great to manage this fix as soon as possible |
|
Hi @ovdsteen Do you know if this fix will be available soon? Thank you! |
Author
No unfortunately. I do not have the rights to merge this PR :( |
|
@reppners @ChristofFritz Can you guys please look into merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not use
event.relatedTargetto check if the native element still contains the dragged element because of a Safari bug withNULLasevent.relatedTargetvalue on thedragleaveevent.See bug on StackOverflow
The solution is to use a counter instead of the related target that decrease on drag leave and increase on drag enter.
The flickering of the elements can be tested with Safari on the demo application (see list and typed)
Related to #155