Ref #17 - Add dndIndex to store the initial drag index of the dragged item #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtraynham
force-pushed
the
track_initial_index
branch
from
d6cea3f to
438d8d8
Compare
Contributor
Author
|
I noticed an issue and it seems this isn't entirely correct. Once drop happens the array may have shifted all the elements and thus the original drag index would be incorrect. Need to rethink this a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17
This stores the initial drag index in the
dndStateand provides it on an extendedDragEventduring any of the link/move/copy/end emitters so a user can properly remove an item, such as in cases like primitives where anindexOfwould otherwise be insufficient.