Merged
Conversation
bgruening
reviewed
Feb 28, 2026
ruff.toml
Outdated
| "*.ipynb" = [ | ||
| "E501", # Allow longer lines in notebooks | ||
| "E402", # Allow imports not at top | ||
| "F401", # Allow unused imports |
Contributor
Author
There was a problem hiding this comment.
Good question, I did this because in notebooks I tend to care a lot less about long lines, they are more draft work. But one could argue if they're worth a commit, maybe it would be nice for them to be clean.
Contributor
Author
There was a problem hiding this comment.
I just removed all relax statements except for the one about imports at top. I'll revisit this with @albangaignard because it's failing on scripts/FAIRassessment/FAIRassessment-expe.ipynb
could be revisited later oc
Collaborator
|
Should we also apply |
Contributor
Author
|
done @arash77 ! |
arash77
approved these changes
Mar 2, 2026
Contributor
Author
|
Thanks @bgruening @arash77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in preparation to merge #40
includes: