-
Notifications
You must be signed in to change notification settings - Fork 841
feat(render): deprecate pretty helper and option #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Bu Kinoshita <6929565+bukinoshita@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
@emiliosheinz is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Deprecates the
prettyhelper andoptions.prettyacross node, browser, and edge render paths. Adds JSDoc and inline comments referencing issue #2426 explaining removal goal (dropping Prettier dependency) and migration (call render then run your own formatter). No runtime behavior change unless consumers check new comments.Follow-up: remove option and dependency in next major after warning period.
Summary by cubic
Deprecates the pretty helper and the options.pretty flag across node, browser, and edge render paths. Adds JSDoc guidance to format rendered HTML yourself; no runtime changes, aligning with the plan to drop the Prettier dependency (see #2426).