Add fixBoundaries option to linearization process #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the linearization process of tracks for alpha analysis, the length is always a bit shorter than it should. This is due to the kMeansClustering algorithm that tends to pull the nodes position towards the center of the track. This effect is diminuished by adding more nodes, but this ends up messing the track reconstruction and length resolution.
To avoid these, we can fix the position of the first and last node to be at the start and end of the track.
Important
This change needs first the addition of the fixBoundaries option in
TRestVolumeHits::kMeansClustering. Approve PR554 before this one