Add DynamoDB metadata store workload #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcholakov
force-pushed
the
pavel/qvzslonrxzxx
branch
2 times, most recently
from
1d0382f to
902d35e
Compare
muhamadazmy
approved these changes
Nov 6, 2025
muhamadazmy
left a comment
muhamadazmy
left a comment
There was a problem hiding this comment.
Thank you @pcholakov for guiding me through this and doing all the work 😅
The change looks good to me. The PR also a good reference to go back to if I need to add make more changes.
pcholakov
force-pushed
the
pavel/qvzslonrxzxx
branch
5 times, most recently
from
516d575 to
3626a25
Compare
pcholakov
force-pushed
the
pavel/qvzslonrxzxx
branch
from
3626a25 to
d5bcda7
Compare
pcholakov
force-pushed
the
pavel/qvzslonrxzxx
branch
from
d5bcda7 to
e07877d
Compare
muhamadazmy
approved these changes
Nov 7, 2025
muhamadazmy
left a comment
muhamadazmy
left a comment
There was a problem hiding this comment.
I left one comment about the ddb table key name
| } else { | ||
| table = new ddb.Table(stack, "DynamoDbMetadataTable", { | ||
| partitionKey: { | ||
| name: "kind", |
There was a problem hiding this comment.
I have changed the partition key name to pk instead of kind (key was a reserved word and did not work)
Suggested change
| name: "kind", | |
| name: "pk", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.