expose report metrics section as prometheus metrics #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UiP9AV6Y
force-pushed
the
feature_report_metrics
branch
from
486f065 to
c6c0590
Compare
this change parses additional sections from the report metrics. while all section have a *total* metric, some have additional information which is also exposed by the collector. for good measure additional testdata was added representing various major puppet versions. the reports where generated using `puppet apply --test` against a minimal catalog. the puppet5 report was generated by a puppet installation from Ubuntu 18.04 upstream, while the others where generated from a Puppet installation from the Puppetlabs repo (also against an Ubuntu 18.04 container) Signed-off-by: Gordon Bleux <33967640+UiP9AV6Y@users.noreply.github.com>
UiP9AV6Y
force-pushed
the
feature_report_metrics
branch
from
c6c0590 to
c741935
Compare
|
@eriksw do you think you could have a look and merge this anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change parses additional sections from the report metrics.
while all section have a total metric, some have additional information which is also exposed by the collector. for good measure additional testdata was added representing various major puppet versions. the reports where generated using
puppet apply --testagainst a minimal catalog. the puppet5 report was generated by a puppet installation from Ubuntu 18.04 upstream, while the others where generated from a Puppet installation from the Puppetlabs repo (also against an Ubuntu 18.04 container)This change is