Skip to content

Implement stalking packet#18

Open
diamondo25 wants to merge 2 commits intoretep998:buis_vana_overhaulfrom
diamondo25:implement-stalking
Open

Implement stalking packet#18
diamondo25 wants to merge 2 commits intoretep998:buis_vana_overhaulfrom
diamondo25:implement-stalking

Conversation

@diamondo25
Copy link
Contributor

This mode will show you people in range that are not visible. I am still not sure what its used for exactly.
Also add some CMSG opcodes

This mode will show you people in range that are not visible. I am still not sure what its used for _exactly_.
Also add some CMSG opcodes
Copy link
Collaborator

@LazyBui LazyBui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this functionality actually do? Is it an official GM functionality? How does it differ from my hacked up follow system? Does it make sense to have them both?

Otherwise, only very minor feedback.

packet_builder builder;
builder
.add<packet_header>(SMSG_STALK_RESULT)
.add<int32_t>(player_ids.size());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint32_t

#define CMSG_KEYMAP 0x85
#define CMSG_STALK_BEGIN 0x8c // Click on yourself in the minimap, and you'll send this packet.
#define CMSG_ALLIANCE 0x8d
#define CMSG_ALLIANCE_DENIED 0x8e
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these necessary? It seems like some of these are related to your other PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants