Skip to content

Conversation

@adamkoch
Copy link

@adamkoch adamkoch commented Oct 9, 2025

My expo project still outputs the iOS directory using objective-c. Looking at the iOS guide for RN (non-expo) I think it should still work fine by adding CodePush to the objective-c files?

I tested by patching locally and it seemed to work fine. But not sure if there was some other reason you only had Swift support.

@adamkoch
Copy link
Author

adamkoch commented Oct 9, 2025

@kit2o

@kit2o
Copy link
Contributor

kit2o commented Oct 10, 2025

@adamkoch what is your SDK version? can you share your patch via PR?

@adamkoch
Copy link
Author

I am using expo + react-native-tvos:

"expo": "^52.0.47",
"react-native": "npm:react-native-tvos@~0.76.9-0",
"@revopush/expo-code-push-plugin": "^1.0.1",
"@revopush/react-native-code-push": "^1.4.0",

Here is the patch I'm using:
@revopush+expo-code-push-plugin+1.0.1.patch

After testing a bit more, I am running into a few oddities though with fonts loading (iOS) and resources loading (Android) after applying a patch. I'm not sure if it's related to this or something to do with expo. Basically after patch those resources are not loading correctly so images/fonts are missing. Even though I see all the resources in the patch themselves. What's strange is it doesn't seem to always happen, sometimes it works fine.

On iOS the crash looks like this (fails to load a font):

Error: Calling the 'loadAsync' function has failed
→ Caused by: Registering 'material' font failed with message: 'Font registration was unsuccessful.'. CTFontManagerError code: 101
    at construct (native)
    at apply (native)
    at _construct (app:///main.jsbundle:8711:67)
    at Wrapper (app:///main.jsbundle:8683:25)
    at construct (native)
    at _callSuper (app:///main.jsbundle:52289:170)
    at CodedError (app:///main.jsbundle:52300:25)

On Android it looks like this (fails to load an expo image asset):

Error: Call to function 'ExpoAsset.downloadAsync' has been rejected.
→ Caused by: Unable to download asset from url: file:///data/user/0/tv.mypackage/files/CodePush/4961b56d1d1caaa762eef517ad513d6f99450e57ad3e5662b530c704c57b0de3/raw/node_modules_e...
    at → Caused by: Unable to download asset from url:  (app:///index.android.bundle)
    at construct (native)
    at apply (native)
    at _construct (app:///index.android.bundle:8689:67)
    at Wrapper (app:///index.android.bundle:8661:25)
    at construct (native)
    at _callSuper (app:///index.android.bundle:52554:170)
    at CodedError (app:///index.android.bundle:52565:25)

@adamkoch
Copy link
Author

Update: the errors with iOS and Android appear unrelated to the PR.

iOS - was a metro bundler config (my fault)
Android - I use some SVGs with expo-image which don't appear to load after patch. I'm guessing expo does some conversion in the full build but not on the metro export. Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants