Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR just to keep the following comment around for when I go back to it ^^
As of Puma 6.1.0,
sd_notifyis bundled and not required in our Gemfile: puma/puma#3011Look at bootsnap to precompile the cache? And also purge the cache on a new deploy?
It looks like
RAILS_LOG_TO_STDOUTis not needed anymore as of Rails 7.1 (https://github.com/rezoleo/lea5/pull/440/files#diff-81371ce3a25ba0fd8be1034ca1e3b579e811555de8f73a69283a74e1dbd35a5eR18 and https://github.com/rezoleo/lea5/pull/440/files#diff-881423969f403d8d08f3b51bbb40b56c713b1529f0a0b1cf8c5cccfaf28335b8R16)