Href method added to HyperLink. #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechner
reviewed
Mar 14, 2020
Owner
rflechner
left a comment
rflechner
left a comment
There was a problem hiding this comment.
Thanks for your contrib.
I will try to make this project more testable to facilitate maintainability
| { | ||
| var ret = string.Empty; | ||
| if (node.HasAttributes) | ||
| ret = node.Attributes["href"].Value; |
Owner
There was a problem hiding this comment.
risk of Exception when href is not present
| case ElementSearchKind.Title: | ||
| return from n in html.Descendants(tagName) | ||
| let title = n.GetAttributeValue("title", string.Empty) | ||
| let fixedTitle = title.Replace(" ", " ").Trim() |
Owner
There was a problem hiding this comment.
This will only treat double spaces cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method returns the value of the href.