Skip to content

Conversation

@johnrey1
Copy link

@johnrey1 johnrey1 commented Jul 6, 2019

…multiple cookies #1

ran into same issue getting back a multi-cookie list where origin server separated by comma.

added a split on comma before the regex step

Copy link
Owner

@rflechner rflechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contrib, could you please add unit tests for this class to avoid any regression ?
They are missing in this project 😄

@johnrey1
Copy link
Author

johnrey1 commented Jun 8, 2020

added a few unit tests. it's been a long time looking at the code. I tried to find the host server I used that returned me CSV cookies. I couldnt find it.
It's not standard to use CSV, just semi-colon separated. But I have run across old web servers that do.
I changed the code a bit, and created a separate regex to use in the case where a ';' does not exist in the cookie string.

let me know if this works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants