Skip to content

Describe specifier_syntax#50

Merged
rgommers merged 12 commits intorgommers:pep-name-mappingfrom
jaimergp:nmp-specifier-syntax
Sep 3, 2025
Merged

Describe specifier_syntax#50
rgommers merged 12 commits intorgommers:pep-name-mappingfrom
jaimergp:nmp-specifier-syntax

Conversation

@jaimergp
Copy link
Copy Markdown
Collaborator

@jaimergp jaimergp commented Aug 28, 2025

Describes schema changes done in jaimergp/external-metadata-mappings#22. Closes #45.


📚 Documentation preview 📚: https://pep-previews--50.org.readthedocs.build/

@jaimergp jaimergp marked this pull request as ready for review August 28, 2025 10:04
@jaimergp jaimergp requested a review from rgommers August 28, 2025 10:04
@rgommers
Copy link
Copy Markdown
Owner

rgommers commented Sep 2, 2025

Anything else needed, or shall we merge this as is?

@jaimergp
Copy link
Copy Markdown
Collaborator Author

jaimergp commented Sep 2, 2025

I'm waiting to see if @mgorny likes the additions I made after his feedback. Ah ok, comment clash! hah I'll review.

Perhaps you want to add some more input in this comment, Ralf.

jaimergp and others added 2 commits September 2, 2025 15:44
Co-authored-by: Michał Górny <mgorny@gentoo.org>
Copy link
Copy Markdown

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for bearing with me!

@jaimergp
Copy link
Copy Markdown
Collaborator Author

jaimergp commented Sep 2, 2025

LGTM. Thanks for bearing with me!

Always a pleasure, they were excellent suggestions!

@rgommers rgommers merged commit c98b030 into rgommers:pep-name-mapping Sep 3, 2025
2 of 3 checks passed
@rgommers
Copy link
Copy Markdown
Owner

rgommers commented Sep 3, 2025

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants