Skip to content

Remaining polish and P2 backlog items#56

Merged
rgonek merged 31 commits intomainfrom
codex/live-workflow-findings-remediation
Mar 8, 2026
Merged

Remaining polish and P2 backlog items#56
rgonek merged 31 commits intomainfrom
codex/live-workflow-findings-remediation

Conversation

@rgonek
Copy link
Owner

@rgonek rgonek commented Mar 6, 2026

Summary

Implements the remaining polish and backlog plan from agents/plans/2026-03-07-remaining-polish-and-backlog.md.

P1 — Completed polish items

  • Push preflight enhancement: Preflight now probes remote capabilities (content-status API), reports degraded modes before execution, and shows exact planned page and attachment mutations
  • AGENTS.md template alignment: Replaced split Human-in-the-Loop / Full Agentic workflow with a single unified pull → validate → diff → push workflow; removed stale space frontmatter references; added content support contract and documentation strategy sections

P2 — Backlog items

  • No-op explainability: Pull, push, and preflight now explain why nothing changed (no remote changes, no local changes, out-of-scope updates)
  • Destructive operation previews: Preflight and push show exact pages targeted for archive/delete before safety confirmation
  • Recovery artifact inspection: conf recover uses sectioned output format showing snapshot refs, sync branches, and failed run details
  • Dry-run fixes: Fixed emitOperations flag (body preview was silently suppressed) and cross-space link resolution (sibling spaces now accessible during dry-run)
  • Compatibility matrix: New docs/compatibility.md with feature/tenant compatibility matrix
  • Changelog discipline: New CHANGELOG.md with sync semantics change tracking
  • Beta maturity notices: Added to README, usage.md, and automation.md

Test plan

  • All existing tests pass (go test ./...)
  • New tests for preflight capability concerns, destructive previews, no-op messages, recovery inspection, AGENTS.md template alignment
  • Fixed two pre-existing dry-run test failures (emitOperations, cross-space links)
  • go fmt and go vet clean

🤖 Generated with Claude Code

Robert Gonek and others added 27 commits March 6, 2026 09:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Complete the search hardening, tenant capability fallback, sandbox workflow, and doctor/recover follow-up batch with regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tighten pull/diff warning taxonomy, add actionable diagnostic metadata, and document extension support boundaries explicitly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preflight now creates a remote client to detect degraded modes (content-status
API unavailability), reports capability concerns, and shows exact planned page
and attachment mutations before execution. README updated with beta maturity
notice.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tter model

Replace split Human-in-the-Loop / Full Agentic workflow with a single unified
pull -> validate -> diff -> push workflow. Remove stale `space` frontmatter
references, add content support contract and documentation strategy sections.
Add golden-style tests verifying template alignment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
No-op pull/push/preflight commands now explain why nothing changed (no remote
changes, no local changes, out-of-scope updates, etc.). Fix dry-run to use
the original space dir instead of a temp copy so sibling space directories
remain accessible for cross-space link resolution. Enable emitOperations on
dry-run remote so body preview output is visible.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Preflight and push now show exact pages targeted for archive/delete before
safety confirmation. Recovery inspection (conf recover) uses a sectioned
output format showing snapshot refs, sync branches, and failed run details.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New docs/compatibility.md with feature/tenant compatibility matrix. New
CHANGELOG.md with sync semantics change tracking discipline. Beta maturity
notices added to usage.md and automation.md.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rgonek rgonek changed the title Fix content-status sync and rollback cleanup Remaining polish and P2 backlog items Mar 8, 2026
rgonek and others added 2 commits March 8, 2026 20:29
The test pre-seeded the index with path "DOCS/page.md" which doesn't
exist on disk. IncrementalUpdate's removeDeletedPaths purged it as
stale, leaving ListSpaces with nothing to return. Changed to
"DOCS/overview.md", the file setupSearchTestRepo actually creates.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- TestRunInit_ExistingDotEnvRemainsUnchanged: add setupGitRepo so git
  user identity is configured before runInit attempts an initial commit

- TestSaveAndLoadState_NormalizesPathSeparators: prepend
  strings.ReplaceAll to normalizeStatePath so backslash literals are
  converted to forward slashes on Linux (filepath.ToSlash is a no-op
  there)

- TestNormalizePullAndPushState_NormalizeAllPathIndexes: same fix in
  normalizeRelPath in pull_paths.go

- TestPull_ConcurrentPageDetails: guard GetFolder and GetContentStatus
  in fakePullRemote with a mutex to eliminate the data race detected
  under -race

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rgonek and others added 2 commits March 8, 2026 20:50
- Deleted full-text search plan as it is no longer relevant.
- Removed refactor plan for large files to streamline codebase.
- Eliminated self-healing sync and deterministic hierarchy plan, as features have been implemented.
- Discarded test coverage extension plan to focus on current testing strategies.
- Updated AGENTS.md template to clarify guidance on copying pages.
- Adjusted init command documentation to remove references to documentation strategy.
- Cleaned up project.md to clarify the purpose of implementation plans and their historical context.
gosec: add //nolint:gosec to three os.ReadFile calls (test temp paths
and recovery metadata path) and the uintptr→int conversion in
resolveSearchFormat.

unused: delete nine dead functions that had no callers —
printNoIndexDiff, prepareDryRunSpaceDir, copyDirTree,
appendPushResultToReport, pushOperationByPath, normalizeReportPushPath,
commandRunReport.absorb, movedPageIDs, pushChangesNeedMetadataSync.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rgonek rgonek merged commit 555c6e4 into main Mar 8, 2026
2 checks passed
@rgonek rgonek deleted the codex/live-workflow-findings-remediation branch March 9, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant