Merged
Conversation
…kspace specification document
Preserve local edits during automatic pull-merge, fix file-target validation in push worktrees, and restore attachment/date round-trips in live sync flows. Verified with focused internal/sync tests, focused cmd tests, and the four live E2E workflows for pull-merge, plain ISO date stability, attachment publication round-trip, and cleanup parity.
- Added `pushDeletePage` function to handle the deletion and archiving of pages in Confluence. - Implemented `pushUpsertPage` function to manage the creation and updating of pages, including attachment handling and conflict resolution. - Introduced rollback mechanisms for safe operations during push mutations. - Enhanced diagnostics for better error tracking and reporting during push operations. - Integrated asset management for attachments, ensuring proper upload and deletion based on references in markdown documents.
- Moved `preparePushRepoWithBaseline` and `preparePushRepoWithLinkedChildBaseline` functions to `push_test_helpers_test.go`. - Removed redundant code from `push_test.go` to improve readability and maintainability. - Introduced a fake push remote struct and its methods to facilitate testing without affecting the actual remote.
- Implement tests for folder fallback behavior when folder listing fails. - Add tests to ensure diagnostics are deduplicated for folder hierarchy resolution. - Create tests for incremental pull operations, including handling deletions and watermark updates. - Introduce tests for state management during pulls, ensuring drafts and trashed pages are handled correctly. - Validate preservation of absolute cross-space links without unresolved warnings.
- Refactor folder hierarchy management to improve compatibility and error handling. - Introduce diagnostics for folder API failures, falling back to page-based hierarchy when necessary. - Update tests to cover new folder handling logic and ensure proper diagnostics are emitted. - Add a live sync test log for comprehensive verification of push/pull functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing