Skip to content

Scanf has been replaced by getline #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Scanf has been replaced by getline #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
049c6b6
Scanf has been replaced by getline
jridky Mar 31, 2016
2740d41
Memory leek fixed
jridky Apr 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/client/client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,15 +528,19 @@ int rpm_process(GSList *install, GSList *update, GSList *erase) {

int question(char* question, int possibilities) {
int status = NO, repeat = 1;
char answer;
char *answer = NULL, letter;
Copy link

@msekletar msekletar Apr 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me there is a memory leak because answer is never freed.

Copy link
Collaborator Author

@jridky jridky Apr 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you.

switch(possibilities)
{
case YES_NO:
while(repeat) {
rds_log(logQUESTION, "%s\n[y/n]: ", question);
scanf("%c", &answer);
if(getline(&answer, &size, stdin) == -1){
// TODO error message after log reimpmelentation
}else{
letter = answer[0];
}

switch(answer)
switch(letter)
{
case 'y':
status = YES;
Expand All @@ -549,7 +553,6 @@ int question(char* question, int possibilities) {

default:
rds_log(logWARNING, "Unsupported answer. You should choose y for yes or n for no.\n");
scanf("%c", &answer); //eliminating enter
break;
}
}
Expand All @@ -559,9 +562,13 @@ int question(char* question, int possibilities) {
while(repeat)
{
rds_log(logQUESTION, "%s\n[y/n/d]: ", question);
scanf("%c", &answer);

switch(answer)
if(getline(&answer, &size, stdin) == -1){
// TODO error message after log reimpmelentation
}else{
letter = answer[0];
}

switch(letter)
{
case 'y':
status = YES;
Expand All @@ -579,12 +586,16 @@ int question(char* question, int possibilities) {

default:
rds_log(logWARNING, "Unsupported answer. You should choose y for yes, n for no or d for download only.\n");
scanf("%c", &answer); //eliminating enter
break;
}
}
break;
}

if(answer != NULL){

free(answer);
}

return status;
}