Conversation
to content from gnome-ponytail-daemon-0.0.11-5.el10
On the contemporary RHEL-10 composes, it sometimes happens that the first click on a button (on welcome screen) doesn't do anything, and the subsequent actions naturally fail. Adding a dummy click before performing an actual button click works around this problem.
A new version of at-spi2 renamed the button ATK node type from 'push button' to 'button', thus we need to take this into account and translate the calls to make the existing code work. The ideal solution would be to use node types from Atspi.Role enum instead of the string identifiers, but refactoring the code doesn't look to be worth the effort.
jstodola
approved these changes
Aug 7, 2025
Collaborator
jstodola
left a comment
jstodola
left a comment
There was a problem hiding this comment.
It looks good to me, thanks for the fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
push buttontobutton. It would be easy to replace all occurrences, but we need to retain backward compatibility (mainly for RHEL-9), so I'm introducing a check for this node name change that will eventually translate all of the relevant function calls usingpush button.Changes tested on both RHEL-9.7 and RHEL-10.1.
The ideal solution would be to identify the node types by values from
Atspi.Roleinstead of strings (e. g.BUTTONorPUSH_BUTTON, instead of the strings). However, it doesn't seem the benefits would outweigh the effort needed to implement such changes.Another option could be to use a newer version of dogtail and provide a specific configuration file for dogtail, but again, from what I've learned, I'm under an impression that this is rather a temporary workaround in dogtail and it's not guaranteed to work also in the future.