Conversation
M4rtinK
left a comment
M4rtinK
left a comment
There was a problem hiding this comment.
Maybe you could use fragment/s for the generic part of the kickstart file ? Otherwise looks good. :)
| network --bootproto=dhcp | ||
|
|
||
| bootloader --timeout=1 | ||
| zerombr |
There was a problem hiding this comment.
I wonder if using some fragments could prevent duplication ? For example, I don't think the storage section is specific to this test & could be replaced by: https://github.com/rhinstaller/kickstart-tests/blob/master/fragments/shared/storage/default.ks
Or possibly the full common_no_payload ?
https://github.com/rhinstaller/kickstart-tests/blob/master/fragments/shared/common/common_no_payload.ks
There was a problem hiding this comment.
This is taken from the ftp test. Let's use it this way and I can take a look on the optimization of both in next PR.
jkonecny12
force-pushed
the
add-ftp-with-proxy
branch
from
7cfa351 to
01edc68
Compare
|
UPDATED:
|
jkonecny12
force-pushed
the
add-ftp-with-proxy
branch
from
01edc68 to
d3de869
Compare
|
Rebased to resolve smaller conflict. |
|
/test-tmt |
|
/test-os-variants |
jkonecny12
force-pushed
the
add-ftp-with-proxy
branch
from
d3de869 to
94fa03d
Compare
|
/test-tmt |
|
/test-os-variants |
jkonecny12
force-pushed
the
add-ftp-with-proxy
branch
from
94fa03d to
0cdfc68
Compare
|
/test-tmt |
1 similar comment
|
/test-tmt |
jkonecny12
force-pushed
the
add-ftp-with-proxy
branch
from
c43cf6f to
0cdfc68
Compare
|
/test-tmt |
3 similar comments
|
/test-tmt |
|
/test-tmt |
|
/test-tmt |
Squid prints file name in the middle of the line not on the end. Maybe change in the squid logging?
We have only one now but next one is coming.
Test if FTP installation with `inst.proxy` works as expected. To be able to support this we need to allow more ports in the squid.
jkonecny12
force-pushed
the
add-ftp-with-proxy
branch
from
0cdfc68 to
cbe443b
Compare
|
/test-tmt |
|
Rebasing and rerunning to test out change from #1340 |
|
/test-tmt |
|
No it doesn't helped :( |
2 participants
Add a new test ftp-proxy which will use proxy server together with FTP installation source.
This PR is also:
ftptest groupThis PR is blocked by a lot of fixes:
defaultssourcing for platform #1280 (load correctdefaultsfile on RHEL)