Open
Conversation
jkonecny12
reviewed
Nov 7, 2024
Comment on lines
+48
to
+54
| CONFIG_FILE_PATH = '/tmp/ignored_simple_tests.conf' | ||
|
|
||
| # Read additional ignored messages from the config file | ||
| if os.path.isfile(CONFIG_FILE_PATH): | ||
| with open(CONFIG_FILE_PATH, 'r') as config_file: | ||
| extra_ignored_tests = [line.strip() for line in config_file if line.strip()] | ||
| # Extend the ignored_simple_tests list | ||
| ignored_simple_tests.extend(extra_ignored_tests) |
Member
There was a problem hiding this comment.
This solution is not inline with what we are doing elsewhere and also it will be taken by all the tests in parallel because the file is available to all.
Contributor
Author
There was a problem hiding this comment.
You're right, it didn't occur to me that it actually behaves that way. I've edited the code and it should be fine now. I've tested everything.
adamkankovsky
force-pushed
the
ignored-simple-tests
branch
3 times, most recently
from
38d6be1 to
4fe479b
Compare
Contributor
Author
|
/test-os-variants |
Contributor
Author
|
/test-tmt |
KKoukiou
reviewed
Nov 7, 2024
Contributor
KKoukiou
left a comment
KKoukiou
left a comment
There was a problem hiding this comment.
Can you revert the merged PR with the adjust pre-install test as part of this PR so that we can test that it works :)
adamkankovsky
force-pushed
the
ignored-simple-tests
branch
from
4fe479b to
53fd0d9
Compare
adamkankovsky
force-pushed
the
ignored-simple-tests
branch
from
53fd0d9 to
57823ca
Compare
Contributor
Author
|
/test-tmt |
Contributor
Author
|
/test-os-variants |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.