-
Notifications
You must be signed in to change notification settings - Fork 73
feat: UIPlugin API - introduce new flag for components health #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tremes The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I think this component becomes a backend component, even if its related to the UI. Similar to korrel8r, the UIPlugin drives the installation. But in the future, we will converge all the plugins into Perses dashboards, meaning the UI might not drive anymore what backend components are installed. Users or Perses will discover and configure available datasources in the cluster, including korrel8r and the health analyzer. So maybe we should think about either leveraging the ObservabilityInstaller CR or add something new. |
|
The alternative is to introduce a new capability in the observabilityInstaller #966. I think this requires some discussion too and opens some new questions like:
|
f678ae4 to
99d9df3
Compare
| maxItems: 2 | ||
| type: array | ||
| x-kubernetes-list-type: atomic | ||
| mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what mode means, it seems it would be the same as only having features either empty, filled with some features or with all features. So it seems redundant and probably confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent here was actually to make it easier to enable all the health related features with mode=All.
The feature granularity (for one backend - health analyzer) appears to be somewhat high.
This is a proposal for a new feature flag for the monitoring uiplugin to enable components health evaluation (with kubehealth OBSDA-1293)
Backend is already implemented in thecluster-health-analyzer. Other options I see:don't add any new boolean flag and "hide" this under the existing "Incident detection" feature - probably OK for now, but not sure about the futurerename the currentIncidentsReferenceattribute to something more general - breaking change (we still have thev1alpha1version) -> a lot of work for documentation and maybe also migration for existing users