Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Dec 4, 2025

This is a proposal for a new feature flag for the monitoring uiplugin to enable components health evaluation (with kubehealth OBSDA-1293)

Backend is already implemented in the cluster-health-analyzer. Other options I see:

  • don't add any new boolean flag and "hide" this under the existing "Incident detection" feature - probably OK for now, but not sure about the future
  • rename the current IncidentsReference attribute to something more general - breaking change (we still have the v1alpha1 version) -> a lot of work for documentation and maybe also migration for existing users

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tremes
Once this PR has been reviewed and has the lgtm label, please assign marioferh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor

I think this component becomes a backend component, even if its related to the UI. Similar to korrel8r, the UIPlugin drives the installation. But in the future, we will converge all the plugins into Perses dashboards, meaning the UI might not drive anymore what backend components are installed. Users or Perses will discover and configure available datasources in the cluster, including korrel8r and the health analyzer. So maybe we should think about either leveraging the ObservabilityInstaller CR or add something new.

@tremes
Copy link
Contributor Author

tremes commented Dec 9, 2025

The alternative is to introduce a new capability in the observabilityInstaller #966. I think this requires some discussion too and opens some new questions like:

  • what all should be installed/deployed in this case (health-analyzer, korrel8r, no uiplugins?) ?
  • if this new capability also installs backend for the incident detection (health-analyzer) then how it goes in hand with the existing monitoring plugin?

@tremes tremes force-pushed the uiplugin-api-update branch from f678ae4 to 99d9df3 Compare December 12, 2025 14:25
maxItems: 2
type: array
x-kubernetes-list-type: atomic
mode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what mode means, it seems it would be the same as only having features either empty, filled with some features or with all features. So it seems redundant and probably confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent here was actually to make it easier to enable all the health related features with mode=All.

The feature granularity (for one backend - health analyzer) appears to be somewhat high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants