Skip to content

Conversation

@simonpasquier
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from jan--f and slashpai December 9, 2025 10:38
@openshift-ci openshift-ci bot added the approved label Dec 9, 2025
### Create a Project to deploy MonitoringStack


```yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can get rid of the snippets in here so we don't have to keep them synced with docs/user-guides/federation/manifests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we could use something like mdox to inject the manifests into the doc but i didn't want to go too deep into the rabbit hole.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, even better.
we could also

kubectl apply -f - <<EOF
...
EOF

around the existing snippets so we don't have to create any bond with manifests/

but yes, let's worry about this later.

Copy link

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't (re)run the commands but lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1b6a208 into rhobs:main Dec 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants