Skip to content

Conversation

@jeroen
Copy link
Contributor

@jeroen jeroen commented Oct 22, 2020

This is a prerequisite for a user that is working on SSL support.

Also, the chocolately redis-64 package seems to be deprecated, and is now a virtual package that installs another one. From the description:

The MS Open Tech Redis on Windows was frozen at version 3.x when it was archived few years ago. Since that time there were a few new major releases of Redis on Linux. Reading the release notes for Redis 4.x and Redis 5.x, one can see that there are several security vulnerabilities that were fixed since.
The current package might pose risk to systems and it is better to retire it. As an alternative to the old package we recommend using Memurai which is on par with Redis 5.x and has the known security vulnerabilities addressed.

Copy link
Owner

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeroen; looks like you're hitting some CI rot here, and I'll need to do some work to patch up the travis builds, which I'll probably port over to GHA at the same time. I don't have time to do this in the next week or two probably, but will try and look at this shortly...

appveyor.yml Outdated
Comment on lines 16 to 17
# - redis-server --service-install
# - redis-server --service-start
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - redis-server --service-install
# - redis-server --service-start

Looks like these are not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll remove those

@jeroen
Copy link
Contributor Author

jeroen commented Oct 22, 2020

OK, the changes in this PR are Windows only, so unrelated to Travis (the appveyor build passes). So I think you can go ahead and merge this to unblock Jeremy.

@richfitz
Copy link
Owner

This has been cherry-picked into #38, thanks @jeroen

@richfitz richfitz closed this Oct 30, 2020
@jeroen jeroen deleted the winlib branch October 30, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants