Skip to content

Fix dropped query param in WS uri. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jkarni wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dropped query param in WS uri. #88

jkarni wants to merge 1 commit into from

Conversation

@jkarni
Copy link

@jkarni jkarni commented Jan 10, 2018 

Slack started adding query params (e.g. "?dp=1") to some of the WSS
urls it sends back. These were being dropped by parseWebSocketUrl,
resulting in empty responses and the following message:

    "{}"
    Error in $: key "ok" not present
    Please report this failure to the github issue tracker

Fixes #87

Fix dropped query param in WS uri.
00eb50b 
    Slack started adding query params (e.g. "?dp=1") to some of the WSS
    urls it sends back. These were being dropped by parseWebSocketUrl,
    resulting in empty responses and the following message:

        "{}"
        Error in $: key "ok" not present
        Please report this failure to the github issue tracker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jkarni