Skip to content

Conversation

@Shane-XB-Qian
Copy link

modification was on v1.5

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
@rickhowe
Copy link
Owner

Could you show me the problem? Currently the plugin monitors WinScrolled event to adjust the wrapwidth virtual spaces in all buffers.

@Shane-XB-Qian
Copy link
Author

Shane-XB-Qian commented Dec 30, 2023 via email

@rickhowe
Copy link
Owner

I implemented the action for BufEnter in ver 3.0. Please try.

@Shane-XB-Qian
Copy link
Author

I implemented the action for BufEnter in ver 3.0. Please try.

thanks. yes, i tried, but not work well.
seems you did not persist s:ww value to buf, after ctrl-^ back, the value lost.
// and TBH: current the code logic after v1.5 seems quite complex, 😄

@rickhowe
Copy link
Owner

Could you try it on update 3.1? Looks like ctrl-^ works well.

@Shane-XB-Qian
Copy link
Author

Could you try it on update 3.1? Looks like ctrl-^ works well.

  1. yes, now it persisted the buf values of wrapwidth.
  2. but it lost wrap somehow now: e.g line#39 of your readme.md after ctrl-^ back, if wrap at '78', the last word 'all' still at same line.
  3. your code in dos format, should convert to unix.

@Shane-XB-Qian
Copy link
Author

or i am actually ok with v1.5, i may just use this to view some markdown, would not edit with it.
so if you thought this change made your plugin too complex, then let it be,
my change on v1.5 already seems workable to me.

or if you'd like to fix it strongly, then i guess i would continue to help you test/verify the change, 😄

@rickhowe
Copy link
Owner

  1. but it lost wrap somehow now: e.g line#39 of your readme.md after ctrl-^ back, if wrap at '78', the last word 'all' still at same line.

I can not reproduce it. 'all' is broken to 'a' and 'll' before and after ctrl-^. I am using vim 9.1 on WIndows 10.

  1. your code in dos format, should convert to unix.

Thank you. I fixed and pushed the plugin. My git might change LF to CRLF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants