Skip to content

cprotect was not actually preventing craz…#146

Open
jservonnat wants to merge 1 commit intomasterfrom
fix_cprotect_craz
Open

cprotect was not actually preventing craz…#146
jservonnat wants to merge 1 commit intomasterfrom
fix_cprotect_craz

Conversation

@jservonnat
Copy link
Collaborator

…of erasing the protected file; here I propose a fix (loop on elements of the cache and cdrop) to ensure that a protected file remains in the cache (unless force=True is specified)

…le; here I propose a fix (loop on elements of the cache and cdrop) to ensure that a protected file remains in the cache (unless force=True is specified)
@jservonnat
Copy link
Collaborator Author

@senesis I'm interested to have your opinion on this point

@senesis
Copy link
Collaborator

senesis commented Oct 14, 2019

Hi, Jérôme
The change is fully relevant.
I definitely should have run basic tests on the behaviour of "rm -fR" on non-writeable files !

@jservonnat
Copy link
Collaborator Author

Thank you @senesis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants