-
Notifications
You must be signed in to change notification settings - Fork 0
Best Time to Buy and Sell Stock #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+34
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| //lint:file-ignore U1000 Ignore all unused code | ||
| package besttimetobuyandsellstock | ||
|
|
||
| /* | ||
| 時間:4分30秒 | ||
|
|
||
| 走査している中で現在の値に対して最大の利益を取り得るのは今まで走査してきた中の最小値であるため、最小値を更新した後に、現在の値に対する利益を計算し、それが最大値であれば更新するようにしている。 | ||
|
|
||
| 解いた後に中の変数名と関数名が一緒になってしまっていることに気づいた。 | ||
| */ | ||
| func maxProfitStep1(prices []int) int { | ||
| minPrice, maxValue := prices[0], 0 | ||
| for _, price := range prices { | ||
| minPrice = min(minPrice, price) | ||
| maxValue = max(maxValue, price-minPrice) | ||
| } | ||
| return maxValue | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| //lint:file-ignore U1000 Ignore all unused code | ||
| package besttimetobuyandsellstock | ||
|
|
||
| import "math" | ||
|
|
||
| /* | ||
| 関数名と被らないように変数名を更新したのと、minPriceをmath.MaxIntで初期化することで、たとえ空の入力が渡されたとしてもエラーにならないようにした。 | ||
| */ | ||
| func maxProfit(prices []int) int { | ||
| minPrice, maxValue := math.MaxInt, 0 | ||
| for _, price := range prices { | ||
| minPrice = min(minPrice, price) | ||
| maxValue = max(maxValue, price-minPrice) | ||
| } | ||
| return maxValue | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.